[wp-trac] [WordPress Trac] #23251: Fixed bug where Wordpress tries to unnecessarily set the memory limit
WordPress Trac
noreply at wordpress.org
Sat Feb 2 06:07:57 UTC 2013
#23251: Fixed bug where Wordpress tries to unnecessarily set the memory limit
--------------------------+------------------
Reporter: peterjaap | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.6
Component: General | Version: 2.5
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by nacin):
* milestone: Awaiting Review => 3.6
Comment:
Maybe I missed it then (and now, as I just re-read the ticket), but it
seems that #14889 was primarily hung up on WP_MEMORY_LIMIT possibly being
specified in G, rather than PHP's memory_limit core ini directive. You can
shout in all caps but it isn't very respectful.
I'm fine with a patch along these lines. It would be good to determine
exactly what values of memory_limit we should listen to. For example, it
accounts for case insensitivity, which seems like a good idea. We have
wp_convert_hr_to_bytes() in wp-includes/media.php — should we be moving
that to wp-includes/load.php, improve it directly, and adapt it here?
----
While we don't accept pull requests via Github, you can simply add .diff
or .patch to many GitHub URLs to get valid patches. For example:
https://github.com/WordPress/WordPress/pull/26.diff. We also have no plans
to migrate to GitHub, but that doesn't mean you can't use it to contribute
— http://scribu.net/wordpress/contributing-to-wordpress-using-github.html.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23251#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list