[wp-trac] [WordPress Trac] #26728: Previous fix for get_queried_object, gives notices for tax queries

[WordPress Trac]

#26728: Previous fix for get_queried_object, gives notices for tax queries
--------------------------+--------------------
 Reporter:  layotte       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.8.1
Component:  Query         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by Chouby):

 * cc: frederic.demarle@… (added)


Comment:

 I believe that at this point $this->is_tax is always true. So the proposed
 patch should reintroduce the bug corrected in [26864]. I thus propose to
 test for:
 {{{
 empty($query['terms'])
 }}}
  instead of only
 {{{
 $query['terms']
 }}}
 That would be strange enough if this notice was not present in WP < 3.8
 since [26864] reintroduced the test exactly as it was before [26007].

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26728#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software