[wp-trac] [WordPress Trac] #20220: add test to see if sunrise === on in ms-settings

[WordPress Trac]

#20220: add test to see if sunrise === on in ms-settings
-------------------------+----------------------
 Reporter:  sboisvert    |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Multisite    |     Version:  3.0
 Severity:  normal       |  Resolution:  wontfix
 Keywords:  has-patch    |
-------------------------+----------------------

Comment (by pdclark):

 That's a great point, Jeremy.

 There is the `SUNRISE_LOADED` constant for that purpose, but that doesn't
 mean the situation might not apply.

 Looking at
 [https://github.com/search?q=defined%28%27SUNRISE%27%29+in%3Afile+language%3Aphp+user
 %3Awp-plugins&type=Code&ref=searchresults this code search of all plugins
 on wordpress.org], I count only two lines from two plugins that this
 *might* effect, but neither case is critical behavior — both are simply
 checks to display a warning:

 * [https://github.com/wp-plugins/wordpress-mu-domain-
 mapping/blob/f5c0f95049de371c465af216fc754db655d8e77d/domain_mapping.php#L422
 wordpress-mu-domain-mapping]
 * [https://github.com/wp-plugins/yet-another-multi-site-
 manager/blob/d4695d2bfa107f83a19371a502e675702f6789c1/yet-another-multi-
 site-manager.php#L486 yet-another-multi-site-manager]

 The only other cases I saw in plugins either use it as a redundancy for
 checking multisite, or check it correctly:

 * [https://github.com/wp-
 plugins/mailin/blob/0c95c121e89bf3163987fd3e02d0e52d4451b155/compatibility.php#L84
 mailin] — redundantly checking if multisite. Still works.
 * [https://github.com/wp-
 plugins/mailchimp/blob/e6a4f1c3384d8841c48369ffe61ece3e51780807/mailchimp_compat.php#L94
 mailchimp]— same
 * [https://github.com/wp-plugins/all-in-one-seo-
 pack/blob/2eeead62b29916506c2ba214ff89aa1bc1ddad19/aioseop_sitemap.php#L347
 all-in-one-seo-pack] — Does it right.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20220#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software