[wp-trac] [WordPress Trac] #26678: sunrise.php gets included for all values of SUNRISE, including false and 'off'

[WordPress Trac]

#26678: sunrise.php gets included for all values of SUNRISE, including false and
'off'
--------------------------+-----------------------------
 Reporter:  pdclark       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Multisite     |    Version:  trunk
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 The most common example of enabling sunrise.php is to set `define(
 'SUNRISE', 'on' );` in `wp-config.php`. Programmers might expect, then,
 that 'off' would disable it.

 Likewise, the standard for other constants, such as `WP_DEBUG` is `true`
 turns it on, `false` turns it off.

 Right now, any value of SUNRISE, including `define( 'SUNRISE', false );`,
 includes the file.

 Attached patch allows either `false` or `'off'` to disable `sunrise.php`

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26678>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software