[wp-trac] [WordPress Trac] #20633: wp-includes/comment.php:738 - Undefined property: WP_Query::$comments

[WordPress Trac]

#20633: wp-includes/comment.php:738 - Undefined property: WP_Query::$comments
-------------------------------------------------+-------------------------
 Reporter:  markjaquith                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Warnings/Notices                     |  Release
 Severity:  normal                               |     Version:  3.3.2
 Keywords:  has-patch needs-unit-tests           |  Resolution:
  3.8-early                                      |
-------------------------------------------------+-------------------------
Changes (by mdbitz):

 * cc: matt@… (added)


Comment:

 Hi, I've attached a set of unit tests for the ''get_comment_pages_count''
 function. I'd appreciate some feedback on it especially concerning the
 $wp_query portion and ensuring the tests do not modify any of the objects
 for other tests.

 Also please let me know if you feel any logic was overlooked, hopefully
 this will let us close this ticket using one of the methods above. I'm in
 favor of the logic by Kitchin as it does not modify return logic.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20633#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software