[wp-trac] [WordPress Trac] #26623: Make gallery_shortcode more customizable

[WordPress Trac]

#26623: Make gallery_shortcode more customizable
-------------------------+------------------------------
 Reporter:  bradvin      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Gallery      |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:   => has-patch


Old description:

> I want to add a few simple changes to the gallery_shortcode function,
> which will allow for awesome customization possibilities if you are a
> theme or plugin author.
>
> In summary I want to check for a class attribute in the shortcode, and
> add 4 filters to the function.
>
> Details about the patch including a demo plugin which uses the resulting
> code can be found at https://github.com/bradvin/wordpress-gallery-
> interceptor
>
> Here are a list of the changes in detail:
>
> == Class Shortcode Attribute ==
>
> Check for a class attribute in the gallery shortcode. The class (if
> exists) is appended to the gallery container element.
>
> Example:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> [gallery class="foobar"]
>   }}}
> }}}
>
> Results in:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> <div id="gallery-1" class="gallery galleryid-4 gallery-columns-2 gallery-
> size-thumbnail foobar">
>   }}}
> }}}
>
> == gallery_class Filter ==
>
> Introduce a new filter `gallery_class` which can be used by themes or
> plugins to alter the gallery class. I realise that you could just use the
> class shortcode attribute above, but this allows for more customization.
>
> Parameters:
>
> * `$class` - the current gallery class
> * `$selector` - the unique id of the gallery
> * `$attr` - all the gallery shortcode attributes, to allow for maximum
> customization
>
> An example:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> //add a class to the gallery depending on a template tag
>
> function gallery_intercept_class($class, $selector, $attr) {
>         if ( is_page() ) {
>                 return $class . ' page-gallery';
>         }
>         return $class;
> }
> add_filter('gallery_class', 'gallery_intercept_class', 10, 3);
>   }}}
> }}}
>
> == gallery_container_start Filter ==
>
> Introduce a new filter `gallery_container_start` which can be used by
> themes or plugins to alter the gallery container's opening HTML markup.
> You could change the tag or include any other markup you may want to
> introduce.
>
> Paramaters:
>
> * `$html` - the current gallery opening markup (`<div id='$selector'
> class='$gallery_class'>`)
> * `$selector` - the unique id of the gallery
> * `$gallery_class` - the current gallery class
> * `$attr` - all the gallery shortcode attributes, to allow for maximum
> customization
>
> An Example:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> ///change the tag to rather be a ul
>
> function gallery_intercept_container_start($html, $selector,
> $gallery_class, $attr) {
>         return "<ul id='$selector' data-class='$gallery_class'>";
> }
> add_filter('gallery_container_start',
> 'gallery_intercept_container_start', 10, 4);
>   }}}
> }}}
>
> == gallery_container_end Filter ==
>
> Introduce a new filter `gallery_container_end` which, as the name
> suggests, can be used to alter the closing markup of the gallery.
>
> Paramters:
>
> * `$html` - the current gallery closing markup (`<br style='clear: both;'
> /></div>\n`)
> * `$selector` - the unique id of the gallery
> * `$attr` - all the gallery shortcode attributes, to allow for maximum
> customization
>
> An Example:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> ///change the closing tag to a ul
>
> function gallery_intercept_container_end($html, $selector, $attr) {
>         return "</ul> <!-- $selector gallery -->";
> }
> add_filter('gallery_container_end', 'gallery_intercept_container_end',
> 10, 3);
>   }}}
> }}}
>
> == gallery_intercept_separator Filter ==
>
> Introduce a new filter `gallery_intercept_separator` which can be used to
> alter the separator markup of the gallery. This filter can be used to
> override the <br /> tag that is inserted when the column count is met.
>
> Paramters:
>
> * `$html` - the current gallery closing markup (`<br style="clear: both"
> />`)
> * `$selector` - the unique id of the gallery
> * `$attr` - all the gallery shortcode attributes, to allow for maximum
> customization
>
> An Example:
>
> {{{
> #!div style="font-size: 80%"
>   {{{#!php
> //do not output any separator
>
> function gallery_intercept_separator($html, $selector, $attr) {
>         return "<!-- no separator please -->";
> }
> add_filter('gallery_column_separator', 'gallery_intercept_separator', 10,
> 3);
>   }}}
> }}}

New description:

 I want to add a few simple changes to the gallery_shortcode function,
 which will allow for awesome customization possibilities if you are a
 theme or plugin author.

 In summary I want to check for a class attribute in the shortcode, and add
 4 filters to the function.

 Details about the patch including a demo plugin which uses the resulting
 code can be found at https://github.com/bradvin/wordpress-gallery-
 interceptor

 Here are a list of the changes in detail:

 == Class Shortcode Attribute ==

 Check for a class attribute in the gallery shortcode. The class (if
 exists) is appended to the gallery container element.

 Example:

 {{{
 #!div style="font-size: 80%"
 [gallery class="foobar"]
 }}}

 Results in:

 {{{
 #!div style="font-size: 80%"
 <div id="gallery-1" class="gallery galleryid-4 gallery-columns-2 gallery-
 size-thumbnail foobar">
 }}}

 == gallery_class Filter ==

 Introduce a new filter `gallery_class` which can be used by themes or
 plugins to alter the gallery class. I realise that you could just use the
 class shortcode attribute above, but this allows for more customization.

 Parameters:

 * `$class` - the current gallery class
 * `$selector` - the unique id of the gallery
 * `$attr` - all the gallery shortcode attributes, to allow for maximum
 customization

 An example:

 {{{
 #!php
 //add a class to the gallery depending on a template tag

 function gallery_intercept_class($class, $selector, $attr) {
         if ( is_page() ) {
                 return $class . ' page-gallery';
         }
         return $class;
 }
 add_filter('gallery_class', 'gallery_intercept_class', 10, 3);
 }}}

 == gallery_container_start Filter ==

 Introduce a new filter `gallery_container_start` which can be used by
 themes or plugins to alter the gallery container's opening HTML markup.
 You could change the tag or include any other markup you may want to
 introduce.

 Paramaters:

 * `$html` - the current gallery opening markup (`<div id='$selector'
 class='$gallery_class'>`)
 * `$selector` - the unique id of the gallery
 * `$gallery_class` - the current gallery class
 * `$attr` - all the gallery shortcode attributes, to allow for maximum
 customization

 An Example:

 {{{
 #!php
 ///change the tag to rather be a ul

 function gallery_intercept_container_start($html, $selector,
 $gallery_class, $attr) {
         return "<ul id='$selector' data-class='$gallery_class'>";
 }
 add_filter('gallery_container_start', 'gallery_intercept_container_start',
 10, 4);
 }}}

 == gallery_container_end Filter ==

 Introduce a new filter `gallery_container_end` which, as the name
 suggests, can be used to alter the closing markup of the gallery.

 Paramters:

 * `$html` - the current gallery closing markup (`<br style='clear: both;'
 /></div>\n`)
 * `$selector` - the unique id of the gallery
 * `$attr` - all the gallery shortcode attributes, to allow for maximum
 customization

 An Example:

 {{{
 #!php
 ///change the closing tag to a ul

 function gallery_intercept_container_end($html, $selector, $attr) {
         return "</ul> <!-- $selector gallery -->";
 }
 add_filter('gallery_container_end', 'gallery_intercept_container_end', 10,
 3);
 }}}

 == gallery_intercept_separator Filter ==

 Introduce a new filter `gallery_intercept_separator` which can be used to
 alter the separator markup of the gallery. This filter can be used to
 override the <br /> tag that is inserted when the column count is met.

 Paramters:

 * `$html` - the current gallery closing markup (`<br style="clear: both"
 />`)
 * `$selector` - the unique id of the gallery
 * `$attr` - all the gallery shortcode attributes, to allow for maximum
 customization

 An Example:

 {{{
 #!php
 //do not output any separator

 function gallery_intercept_separator($html, $selector, $attr) {
         return "<!-- no separator please -->";
 }
 add_filter('gallery_column_separator', 'gallery_intercept_separator', 10,
 3);
 }}}

--

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26623#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software