[wp-trac] [WordPress Trac] #26403: Convert path to lower case before matching for blog

[WordPress Trac]

#26403: Convert path to lower case before matching for blog
--------------------------+------------------
 Reporter:  codix         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  low           |   Milestone:  3.9
Component:  Multisite     |     Version:  3.0
 Severity:  minor         |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------
Changes (by jeremyfelt):

 * keywords:   => dev-feedback
 * priority:  normal => low
 * version:  3.8 => 3.0
 * severity:  normal => minor
 * milestone:  Awaiting Review => 3.9


Comment:

 We use `strtolower()` when creating new sites and users. We also use it in
 `get_blog_id_from_url()`.

 It seems not using `strtolower()` when looking for the site *could* cause
 an issue if the database collation was set in a way that made the query
 for path case sensitive. Adding that to `ms-settings.php` would likely not
 hurt.

 I don't understand the removal of the case insensitive flag in
 `parse_request()`, that seems like an unnecessary change that could go
 against the goal of being case insensitive.

 Moving to 3.9 as it's worth discussing `strtolower( $path )` as part of
 our site matching.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26403#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software