[wp-trac] [WordPress Trac] #23050: make_clickable incorrectly formats anchors with URL's and spaces in them in comments

WordPress Trac noreply at wordpress.org
Wed Dec 11 19:24:42 UTC 2013


#23050: make_clickable incorrectly formats anchors with URL's and spaces in them in
comments
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Formatting       |     Version:  3.4.2
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |
-----------------------------+------------------------------

Comment (by beaulebens):

 Using a similar approach to #23756 might make sense here. Example patch
 attached (which includes compacting the initial regex into a single one,
 vs introducing a third) and moving the `$nested_code_pre` check in the
 `elseif` to the start to avoid doing string operations if unnecessary.

 I have not run the unit tests because I don't currently have them set up
 :)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23050#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list