[wp-trac] [WordPress Trac] #25459: Provide more meaningful links in Edit Post/Page
WordPress Trac
noreply at wordpress.org
Tue Dec 10 16:49:54 UTC 2013
#25459: Provide more meaningful links in Edit Post/Page
-----------------------------------------------+---------------------------
Reporter: grahamarmfield | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: Future
Component: Accessibility | Release
Severity: minor | Version: 3.6.1
Keywords: i18n-change has-patch 2nd-opinion | Resolution:
-----------------------------------------------+---------------------------
Comment (by neil_pie):
Replying to [comment:45 GaryJ]:
> neil_pie, I don't think the class name filter serves any benefit here -
there's ~146 occurrences of "screen-reader-text" across all files in WP,
so it's fairly well established and understood. Since the WP admin CSS
requires a consistent class name, I can't see any reason to make it
filterable, even if the intention was to push all instances of "screen-
reader-text" through a new function (which wouldn't necessarily be great
anyway).
Replying to [comment:47 grahamarmfield]:
> Isn't filtering a bit overkill? The direct parameter that defaults to
'screen-reader-text' is easier to use.
If we don't need to provide developers access to edit, remove or add to
the class of this element then it's completely unnecessary. If we do need
to provide access to this class then filtering on it is absolutely the
correct way to go in my opinion. Passing in a parameter to the function
call does not provide enough flexibility, particularly if we are hoping
developers will use this function beyond WP-admin.
One thought now occurs to me - Isn't this classname a temporary fix (
albeit for the foreseeable future ) to the fact that screen readers do not
adequately support ARIA label attributes? Should we be able to switch the
HTML output in the future then this classname would become redundant.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25459#comment:49>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list