[wp-trac] [WordPress Trac] #25964: Appearance Themes: find a way to provide a no-js fallback

WordPress Trac noreply at wordpress.org
Fri Dec 6 16:10:26 UTC 2013


#25964: Appearance Themes: find a way to provide a no-js fallback
-----------------------------+---------------------
 Reporter:  matveb           |       Owner:  nacin
     Type:  defect (bug)     |      Status:  closed
 Priority:  highest omg bbq  |   Milestone:  3.8
Component:  Appearance       |     Version:  trunk
 Severity:  blocker          |  Resolution:  fixed
 Keywords:                   |
-----------------------------+---------------------
Changes (by nacin):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"26726"]:
 {{{
 #!CommitTicketReference repository="" revision="26726"
 No-JavaScript and no-Customizer support for the new Themes screen.

 JavaScript is rarely disabled, but graceful degradation is still
 important. For example, syntax errors can occur, usually with major WP
 updates that overhaul entire experiences and update external libraries
 combined with themes or plugins doing weird or old things. If this error
 is due to their current theme, a user needs to be able to access the
 themes screen to switch away from the theme. A more subtle issue could
 make things painful to diagnose.

 This commit renders the grid in PHP (the template is duplicated, but it
 lightweight, fairly mundane, and easy to sync). On Backbone render, the
 grid is then re-rendered from JavaScript so searches can occur. Customize
 and Live Preview is disabled if JS fails to kick in. If JS is disabled,
 old-school "Preview" links are displayed.

 No-Customizer support: The customizer is only supported when the browser
 supports postMessage (IE8+), and if the frontend is a different domain,
 CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-
 customize "Preview" links should use .hide-if-customize.

 The .load-customize class should be used to declare a link that opens the
 customizer. This enables customize-loader.js to intercept this link and
 load the customizer on top of the current window, making for a smoother
 experience.

 fixes #25964.
 }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25964#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list