[wp-trac] [WordPress Trac] #26446: Travis CI should run jshint
WordPress Trac
noreply at wordpress.org
Fri Dec 6 08:25:03 UTC 2013
#26446: Travis CI should run jshint
-------------------------+------------------------------
Reporter: jorbin | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by bpetty):
Are you sure you want Travis to send notifications every time a commit is
made that violates jshint rules rather than just notifications when the
code actually fails to function properly?
Not everyone realizes this at first, but there is a line you want to draw
here. Add too much into Travis, and everyone gets used to (and starts to
ignore) build failure notifications. I'd also hate to see committers
getting into the habit of committing first, and relying on Travis to run
the tests for them after the fact rather than running the checks before
they commit.
Travis mostly helps ease the pain of testing across multiple environments
while pin-pointing exactly which commit broke it at the same time. I don't
think we really need that to check for jshint violations though. You
already know the location, and the test doesn't need to be run across
multiple build environments. It's simple enough to run on your local dev
machine because you only need to check in one environment, and it
currently only takes 16 seconds to run.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26446#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list