[wp-trac] [WordPress Trac] #26333: svg-painter.js and friends
WordPress Trac
noreply at wordpress.org
Thu Dec 5 06:29:57 UTC 2013
#26333: svg-painter.js and friends
----------------------------+-----------------------
Reporter: azaozz | Owner: azaozz
Type: defect (bug) | Status: reopened
Priority: high | Milestone: 3.8
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: |
----------------------------+-----------------------
Changes (by nacin):
* status: closed => reopened
* resolution: fixed =>
Comment:
In trunk:
* Doesn't work in Chrome. :-( In chrome, $element.css( 'background-image'
) doesn't include quotes or spaces. The regex assumes a space might not be
there, but doesn't account for the lack of a quote. Patch attached; commit
incoming.
* base64 is a immediately-invoked function expression, and it does things
other than defining other functions (speciifcally, the while loop, maybe a
few other things), even though it is only needed in IE9. Can we avoid
initializing all of that unless we need it?
* Can we move this script to wp-admin? [26601] already shifted it to only
being registered in the admin.
* Can we namespace this as wp.svgPainter or something along those lines?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26333#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list