[wp-trac] [WordPress Trac] #25963: Appearance Themes: Backbone.Router should use pushState with ?query type urls
WordPress Trac
noreply at wordpress.org
Wed Dec 4 21:01:19 UTC 2013
#25963: Appearance Themes: Backbone.Router should use pushState with ?query type
urls
-------------------------+--------------------
Reporter: matveb | Owner:
Type: enhancement | Status: new
Priority: high | Milestone: 3.8
Component: Appearance | Version: trunk
Severity: major | Resolution:
Keywords: |
-------------------------+--------------------
Comment (by adamsilverstein):
Replying to [comment:7 ocean90]:
> Currently there is an issue with the browser history and closing the
modal.
>
> * Go to wp-admin/themes.php
> * Open info modal of Twenty Eleven
> * Navigate to the next theme, Twenty Fourteen for me
> * Click browsers back button
> * You should see Twenty Eleven again
> * Try to close the modal
> * '''Modal isn't closed, it shows Twenty Fourteen again'''
> * Try to close the modal again
> * Now it's closed
>
> So if you are using browsers back button x-times you have to click the
modal close icon x-times too.
[attachment: 25963.2.diff] corrects issue with back button - multiple
overlays were being created, this change prevents that. working on
pushState next. please review.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25963#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list