[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel

[WordPress Trac]

#23560: Keyboard Accessibility of Add Media Panel
-------------------------------------+-----------------------------
 Reporter:  grahamarmfield           |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Accessibility            |     Version:  3.5.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------------

Comment (by lessbloat):

 Replying to [comment:29 nacin]:
 >Is there a downside to keeping wp.media.view.FocusManager? That would
 allay a lot of concerns, I think.

 Brought the main media.view.FocusManager structure back in .6.

 > Could you go into more detail as to how it appears to be unnecessary?

 recordTab & updateIndex attempt to track the current tabindex.  From my
 perspective, this is overkill, as it's not really necessary to make this
 all work.

 > I don't think jQuery UI is used here at all, so we'll have to use 9
 instead of $.ui.keyCode.TAB. To be honest, not sure why $.ui.keyCode is
 ever much benefit as long as there is a comment describing the character
 being intercepted.

 Cool. I removed all references to $.ui.

 >I think prop needs to be used instead of attr for aria-checked.

 Nice catch.  Fixed these.

 >Is there a reason why we are focusing on media-modal-close to keep the
 focus inside the media modal? Where does the focus go, otherwise? It
 seemed that this is what the focusManager should be tasked with doing.
 Keeping it and decorating it with this kind of stuff might be better than
 axing it.

 Done. FocusManager.focus() now puts the focus on the first left menu item
 instead calling media-modal-close directly.

 >What is the isIE class meant to target? All IE, including IE10? IE11?

 Currently downloading a Win 8 ISO to check it in IE10, IE11.  It's
 definitely needed <=IE8.

 > This wasn't slated for 3.8 until yesterday; bumping.

 Sorry, my fault.  I had no idea that code freeze was so close. :-(  3.9 it
 is...

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23560#comment:31>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software