[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel
WordPress Trac
noreply at wordpress.org
Wed Dec 4 18:25:12 UTC 2013
#23560: Keyboard Accessibility of Add Media Panel
-------------------------------------+--------------------
Reporter: grahamarmfield | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Accessibility | Version: 3.5.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------
Comment (by nacin):
I would love for this to be in 3.8 but this looks like a ton of code
churn.
Is there a downside to keeping wp.media.view.FocusManager? That would
allay a lot of concerns, I think. "much of it appeared to be unused" is
not particularly comforting. :-) It is also more or less public API, so I
wouldn't want to be accidentally breaking anything. Could you go into more
detail as to how it appears to be unnecessary?
I don't think jQuery UI is used here at all, so we'll have to use 9
instead of $.ui.keyCode.TAB. To be honest, not sure why $.ui.keyCode is
ever much benefit as long as there is a comment describing the character
being intercepted.
I think prop needs to be used instead of attr for aria-checked.
Is there a reason why we are focusing on media-modal-close to keep the
focus inside the media modal? Where does the focus go, otherwise? It
seemed that this is what the focusManager should be tasked with doing.
Keeping it and decorating it with this kind of stuff might be better than
axing it.
What is the isIE class meant to target? All IE, including IE10? IE11?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23560#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list