[wp-trac] [WordPress Trac] #25856: debug of wpautop function with Unit Tests

WordPress Trac noreply at wordpress.org
Wed Dec 4 10:24:25 UTC 2013


#25856: debug of wpautop function with Unit Tests
-------------------------+--------------------
 Reporter:  mdbitz       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.8
Component:  Formatting   |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+--------------------

Comment (by bpetty):

 Yes, this needs more work still, but should have also already been in beta
 for more adequate testing to begin with. Not to say that this doesn't have
 very thorough unit test coverage, that's looking great.

 As mentioned earlier, performance is a big concern here too, so we really
 also need time to put together some profiling data on this one.

 I'd say punt for now.

 Looking back at the unit tests though, I am concerned about where all this
 test content is coming from:

 - Certainly `test_no_format_style_tags()` and
 `test_no_format_script_tags()` don't actually need full code samples to
 test that they work properly, maybe only a couple lines of JS/CSS, and
 preferably something copied from WP itself ideally, rather than some
 random Google Analytics code snippet.
 - Why do we need all these references to some arbitrary (but actually
 real) blog: "blogyul.miqrogroove.com"? Do we have appropriate copyright
 permissions on the content copied from there (arbitrary content published
 on a WP blog isn't automatically GPL)?
 - What is this Romanian text used? It looks like legal code, so I'm
 guessing it might actually be public domain, but not all countries
 actually have public domain, nor does public domain mean the same thing in
 all countries. No-one has even asked or said what it is though and why
 it's safe. I'm certain we can find better test content for that as well.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25856#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list