[wp-trac] [WordPress Trac] #26212: Twenty Fourteen: add arrows for image template navigation
WordPress Trac
noreply at wordpress.org
Wed Dec 4 06:50:20 UTC 2013
#26212: Twenty Fourteen: add arrows for image template navigation
------------------------------+--------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 3.8
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
------------------------------+--------------------
Comment (by celloexpressions):
[attachment:26212.3.diff] is more code churn than I'd like to introduce at
this point, but I did a search & replace so I think we should be okay
([attachment:26212.2.diff] has the whole non-renaming diff). Had to remove
the namespace (which was "slider") from slider.js for obvious reasons.
Also caught an instance of a `:first-chile` selector in ie.css that should
be `:first-child`.
This is definitely a better approach, naming the classes by what they are,
not where, so we can re-use. But the other way also works if we want to
minimize churn.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26212#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list