[wp-trac] [WordPress Trac] #26381: Scaling Image Up Fails Silently

[WordPress Trac]

#26381: Scaling Image Up Fails Silently
--------------------------+------------------------------
 Reporter:  bandonrandon  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * version:  trunk => 3.5


Old description:

> The ability to scale images up was removed (I think in 3.5) and the text
> was changed in r24562 per this ticket #323713.
>
> However, when using the Image editor to scale an image if you enter a
> value larger than the image we still attempt to re-size the image and the
> "Restore Original link appears"
>
> '''To Reproduce'''
>
> 1) Select an image from the media library and click the "Edit Image"
> button
> [[Image(https://i.cloudup.com/FI6vrPykAw-3000x3000.png)]]
>
> 2) Enter dimensions larger than the original dimensions. You will see a
> red "!" as a warning but ignore this and click the "Scale" button
> [[Image(https://i.cloudup.com/00DyBO7Rb5-3000x3000.png)]]
>
> 3) The site will try to re-size the image and gives a success message.
> [[Image(https://i.cloudup.com/VLRLKcN8N5-3000x3000.png)]]
>
> The only problem is that no new image was created. To fix this we either
> need to give a warning and not produce a "Restore Original Image" link or
> prevent the user from clicking the link at all.
>
> My vote is since we already have JavaScript that detects when the image
> is too large the simplest solution would be to disable the "Scale" button
> when the warning "!" shows.

New description:

 The ability to scale images up was removed (I think in 3.5) and the text
 was changed in r24562 per this ticket #23713.

 However, when using the Image editor to scale an image if you enter a
 value larger than the image we still attempt to re-size the image and the
 "Restore Original link appears"

 '''To Reproduce'''

 1) Select an image from the media library and click the "Edit Image"
 button
 [[Image(https://i.cloudup.com/FI6vrPykAw-3000x3000.png)]]

 2) Enter dimensions larger than the original dimensions. You will see a
 red "!" as a warning but ignore this and click the "Scale" button
 [[Image(https://i.cloudup.com/00DyBO7Rb5-3000x3000.png)]]

 3) The site will try to re-size the image and gives a success message.
 [[Image(https://i.cloudup.com/VLRLKcN8N5-3000x3000.png)]]

 The only problem is that no new image was created. To fix this we either
 need to give a warning and not produce a "Restore Original Image" link or
 prevent the user from clicking the link at all.

 My vote is since we already have JavaScript that detects when the image is
 too large the simplest solution would be to disable the "Scale" button
 when the warning "!" shows.

--

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26381#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software