[wp-trac] [WordPress Trac] #25853: Changeset 25696 breaks expected value of argument sent to filter 'retrieve_password_message'

[WordPress Trac]

#25853: Changeset 25696 breaks expected value of argument sent to filter
'retrieve_password_message'
--------------------------+-----------------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Users         |     Version:  3.7
 Severity:  minor         |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+-----------------------------

Comment (by dcavins):

 Replying to [comment:5 nacin]:
 Yes, including the user_login or user object would be an improvement over
 the earlier version of the filter args. The two pieces of information that
 are necessary to create the password recovery link are user_login and the
 key value. So any combination of arguments that can make that happen are
 enough. But if you're only given the key value, you can't easily get the
 user_login.

 Thanks!

 > Right, I figured that sending the existing plain-text key through the
 filter would break the least. Happy to add the hashed value as a new
 argument.
 >
 > I don't think this actually broke anything. Did it? Anyone doing raw
 queries on the DB is going to have a bad time with this change no matter
 what. This was about the email message being sent, not any complex
 operations.
 >
 > I'm OK with passing the hashed value, but it seems like passing the
 user's login (or rather, ID or a user object) might make more sense.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25853#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software