[wp-trac] [WordPress Trac] #26221: Twenty Fourteen: wp_is_mobile() shouldn't be used

WordPress Trac noreply at wordpress.org
Tue Dec 3 21:19:57 UTC 2013


#26221: Twenty Fourteen: wp_is_mobile() shouldn't be used
---------------------------+------------------------------
 Reporter:  dimadin        |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------------------

Comment (by nacin):

 I think I agree with dimadin here. I discussed wp_is_mobile() usage with
 iandstewart before it landed, but this didn't occur to me. I wouldn't call
 this "aggressive" caching, just any kind of caching. Batcache, WP Super
 Cache, W3 Total Cache, any of them.

 In the end, I don't think this is something the theme should be messing
 with. I totally get that we owe it to the world to serve smaller images to
 mobile devices, but this just isn't the right way to do it. We need to be
 dropping a cookie based on bandwidth and/or device. This is not something
 a theme, certainly not a default one, should be doing.

 I'm also not in love with yet another image size, though I can't fault you
 for it. It would be nice to somehow figure out dynamic sizing at one
 point.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26221#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list