[wp-trac] [WordPress Trac] #25073: Heartbeat performance and API improvements
WordPress Trac
noreply at wordpress.org
Mon Dec 2 21:57:49 UTC 2013
#25073: Heartbeat performance and API improvements
----------------------------+-----------------------
Reporter: evansolomon | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone: 3.8
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------
Comment (by azaozz):
> ...breaking wp.heartbeat.interval() seems a bit overboard.
Point taken, fixing :)
> How about something like `$settings['allowSuspension'] = false`.
Using a string gives a bit more context and can eventually be reused with
`$settings['suspend'] = 'enable';`. Also when passing boolean through
JSON, it may go through some typecasting and might end up as `0` or `1` on
the JS side. That's fine as long as we do "truty/falsey" comparisons, but
we are aiming to always do strict comparisons.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25073#comment:32>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list