[wp-trac] [WordPress Trac] #26333: svg-painter.js and friends

[WordPress Trac]

#26333: svg-painter.js and friends
----------------------------+--------------------
 Reporter:  azaozz          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  high            |   Milestone:  3.8
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------

Comment (by nacin):

 I'm OK with svg-painter.js but I don't like how it forks an external
 library in the process. We should look into breaking that out into its own
 file. What was modified and why? Many questions need answering.

 It should also become wp.svgPainter or something along those lines, if it
 is indeed a WP utility. However, it appears to be coded specifically to
 the admin menu. It should be moved to wp-admin in its current state. Or,
 it can become a dependency of common.js, or whatever.

 As azaozz pointed out, jQuery should be a dependency of it, and it should
 be pushed to the footer.

 Finally, wp_color_scheme should be added through script-loader and
 localize().

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26333#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software