[wp-trac] [WordPress Trac] #26119: New admin styling: Remove screen_icon() calls
WordPress Trac
noreply at wordpress.org
Mon Dec 2 16:40:42 UTC 2013
#26119: New admin styling: Remove screen_icon() calls
--------------------------------+-----------------------
Reporter: TobiasBg | Owner: nacin
Type: enhancement | Status: accepted
Priority: highest omg bbq | Milestone: 3.8
Component: Administration | Version: trunk
Severity: minor | Resolution:
Keywords: ui-focus has-patch |
--------------------------------+-----------------------
Changes (by nacin):
* owner: azaozz => nacin
* status: reopened => accepted
Comment:
The original screen icons were rich with detail and worked well in
WordPress 2.7. In 3.2, when things got a bit more streamlined and felt
more like an "app", they seemed somewhat out of place. In 3.8, the new
design flattens and simplifies things. With everything being an icon font,
a 32-pixel version would provide no more detail than a 20-pixel version
used in the menus.
I honestly have zero qualms with deprecating these functions. I'm sorry
that paying customers have WP_DEBUG turned on, but we don't lightly
deprecate things (say, renaming for the sake of renaming). Deprecation
isn't just about "running clean" but about alerting developers to changes
in functionality. I'm OK with un-deprecating them since this happened late
in the cycle, but the first time we get a support thread or ticket asking
why screen_icon() isn't printing anything anymore, I'm going to march over
to this ticket and casually drop a link. :-)
I think a good approach here would be to keep the functions (un-
deprecated) but have them return/echo nothing. We could probably remove
the CSS too, at that point.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/26119#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list