[wp-trac] [WordPress Trac] #24932: HTML5 support for specific features doesn't work.

WordPress Trac noreply at wordpress.org
Sat Aug 31 06:07:50 UTC 2013


#24932: HTML5 support for specific features doesn't work.
------------------------------------------+-----------------------
 Reporter:  nathanrice                    |       Owner:  nacin
     Type:  defect (bug)                  |      Status:  accepted
 Priority:  normal                        |   Milestone:  3.6.1
Component:  Themes                        |     Version:  3.6
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch commit fixed-major  |
------------------------------------------+-----------------------

Comment (by nathanrice):

 If I could, I'd like to formally request that this NOT return false if no
 array of types gets passed.

 Short story, this will break Genesis child themes, which we can't push
 updates to address.

 In Genesis, we only define HTML5 as being on or off. We have no need to
 specify types, since if html5 theme support is added, we don't want
 anything outputting in any other format except for html5.

 I understand the "intended" behavior from the core perspective, but it's
 silly to assume that the following would somehow return false.

 {{{
 add_theme_support( 'html5' );

 return current_theme_supports( 'html5' ); // false?
 }}}

 I'm not trying to pull special privilege here or anything ... but I can't
 stress enough how a 3.6.1 update that includes this short circuit will
 immediately and catastrophically damage the look of sites running Genesis
 2.0 and a child theme that supports HTML5.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24932#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list