[wp-trac] [WordPress Trac] #24932: HTML5 support for specific features doesn't work.

[WordPress Trac]

#24932: HTML5 support for specific features doesn't work.
------------------------------+-----------------------
 Reporter:  nathanrice        |       Owner:  nacin
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  3.6.1
Component:  Themes            |     Version:  3.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by nacin):

 [attachment:24932.diff] makes two functionality changes:
  * Calling `add_theme_support( 'html5', array( 'comments-list' ) );
 add_theme_support( 'html5', array( 'comment-form' ) );` should
 '''merge'''. If a theme wants to ''replace'', they need to do a
 `remove_theme_support( 'html5' )` first. This is a change in behavior that
 we can really only get away with now, in 3.6.1. Reasoning is the mess that
 is #22080.

  * `add_theme_support( 'html5' )` (no arguments) no longer works. This was
 never supposed to work, as it would prevent us from adding future types in
 the future. `current_theme_supports( 'html5' )`, however, does continue to
 work, and will return `true` if *any* feature is supported. This might
 help a plugin author decide what markup to serve, but core should never
 check for this.

 In both cases, this is how the functionality was designed. It just wasn't
 implemented correctly.

 Also adds some unit tests.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24932#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software