[wp-trac] [WordPress Trac] #25088: password-strength-meter.js should have unit tests

WordPress Trac noreply at wordpress.org
Thu Aug 29 04:30:31 UTC 2013


#25088: password-strength-meter.js should have unit tests
----------------------------+------------------
 Reporter:  jorbin          |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.7
Component:  Unit Tests      |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by iandunn):

 It'd also be good to have a test to check the `user_input` field to make
 sure that any extra words that are passed are penalized.
 [http://core.trac.wordpress.org/ticket/21737#comment:41 Currently that's
 broken] because of the modifications that were made to zxcvbn, so a unit
 test would help make sure that doesn't happen again.

 I'm uploading a patch with that added. Note that the test currently fails,
 which is the expected behavior since Jon's latest patch hasn't been
 committed yet.

 password-strength-meter.js also needs some reworking around the JS coding
 standards (using spaces instead of tabs, missing whitespace around
 paranthesis, etc), but I don't have time for that tonight.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25088#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list