[wp-trac] [WordPress Trac] #25161: Define SCRIPT_DEBUG in trunk/src and remove it when building

WordPress Trac noreply at wordpress.org
Wed Aug 28 19:23:50 UTC 2013


#25161: Define SCRIPT_DEBUG in trunk/src and remove it when building
--------------------------+--------------------
 Reporter:  azaozz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.7
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by azaozz):

 > I am not in love with 25161.patch

 Yeah, not particularly happy with it too. Filtering PHP code with a regex
 is not ideal. If we end up doing something like this, at least the filter
 should be really simple.

 Setting something in /src that is removed by Grunt in /build can work. One
 problem is that the `processContentExclude` option on the copy task works
 only on directories, and we don't want to process hundreds or thousands of
 files. We can work around this by setting two 'copy' tasks, the first will
 copy all files except the file(s) need processing and the second will copy
 and process the remaining file(s).

 Thinking the proper place to do this is in version.php. How about we add
 `-src` to the end of `$wp_version`? This will make the filtering regex
 much simpler.

 Another think that can be handled there is cache-busting js and css in
 /build. Bumpbot was pretty good about it, now we need an alternative.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25161#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list