[wp-trac] [WordPress Trac] #20298: Change requires to require_once

WordPress Trac noreply at wordpress.org
Sun Aug 25 17:55:15 UTC 2013


#20298: Change requires to require_once
-------------------------+----------------------
 Reporter:  pp3345       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  General      |     Version:  3.3.1
 Severity:  normal       |  Resolution:  wontfix
 Keywords:               |
-------------------------+----------------------
Changes (by DrewAPicture):

 * keywords:  close =>
 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 See @nacin's comment:4:

 > The include graph for WordPress is something like 100 files so
 [require_once] will definitely be worse for performance, even if barely
 measurable.
 >
 > Additionally, if we change this, we then have to agree to maintain the
 use of require_once always. That kind of commitment (when it doesn't
 benefit us) is difficult to agree to or maintain.
 >
 > More importantly, though, I disagree that require_once is an increase in
 code quality. It can hide problems, silly code, and errors; and indicates
 to me a decrease in quality, if anything.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20298#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list