[wp-trac] [WordPress Trac] #25134: Multisite new site domain name: inconsistency with hyphens ms-functions.php vs site-new.php

WordPress Trac noreply at wordpress.org
Sat Aug 24 18:37:55 UTC 2013


#25134: Multisite new site domain name: inconsistency with hyphens ms-functions.php
vs site-new.php
--------------------------+-----------------------------
 Reporter:  lkraav        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Multisite     |    Version:  trunk
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 [source:trunk/src/wp-includes/ms-functions.php#L557]
 {{{
 if ( preg_match( '/[^a-z0-9]+/', $blogname ) )
 }}}

 vs

 [source:trunk/src/wp-admin/network/site-new.php#L43]
 {{{
 if ( preg_match( '|^([a-zA-Z0-9-])+$|', $blog['domain'] ) )
 }}}

 Yes, I'd really like to have hyphens in my subsite domain names. Blaming
 all the way back to multisite import doesn't reveal any particular
 reasoning why hyphens are historically disallowed. Since hyphens are a
 normal part of the DNS system, I see no reason why they should be banned.

 I would suggest matching also for "-" in ms-functions.php.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25134>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list