[wp-trac] [WordPress Trac] #24987: HTTP requests should handle passing Cookies on redirects

WordPress Trac noreply at wordpress.org
Fri Aug 23 20:22:19 UTC 2013


#24987: HTTP requests should handle passing Cookies on redirects
------------------------------+-----------------------
 Reporter:  dd32              |       Owner:  dd32
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  3.7
Component:  HTTP              |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------
Changes (by dllh):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 If the {{{$response}}} we get back before doing the cookie addition is a
 WP_Error, then we get a "cannot use object of type WP_Error as array"
 error in line 202: {{{$cookies_set = wp_list_pluck( $response['cookies'],
 'name' ); }}}, which results in a fatal error.

 The forthcoming patch avoids the fatal by returning before adding the
 cookies if we've gotten a WP_Error back. Props @nacin.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24987#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list