[wp-trac] [WordPress Trac] #20220: add test to see if sunrise === on in ms-settings
WordPress Trac
noreply at wordpress.org
Thu Aug 22 20:52:25 UTC 2013
#20220: add test to see if sunrise === on in ms-settings
-------------------------+----------------------
Reporter: sboisvert | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Multisite | Version: 3.0
Severity: normal | Resolution: wontfix
Keywords: has-patch |
-------------------------+----------------------
Changes (by nacin):
* status: new => closed
* resolution: => wontfix
* milestone: 3.7 =>
Comment:
If you need to ignore SUNRISE for a particular request, then either A)
don't define it, or B) if it's too late to not define it, just don't do
anything in sunrise.php. WordPress doesn't skip any of its own logic when
sunrise.php is included and does nothing. Ultimately, "We needed to
disable sunrise for certain requests." is just not enough to justify
[attachment:20220.patch] or the like.
And that said, I'm inclined to think that even `false !== SUNRISE` could
break things. There seems to be no inherent harm to the current approach.
Wontfix.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20220#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list