[wp-trac] [WordPress Trac] #24932: HTML5 support for specific features doesn't work.

[WordPress Trac]

#24932: HTML5 support for specific features doesn't work.
--------------------------+--------------------
 Reporter:  nathanrice    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6.1
Component:  Themes        |     Version:  3.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Description changed by SergeyBiryukov:

Old description:

> The check for the second parameter in `current_theme_supports()` in 24417
> is irrelevant.
>
> Unit test here:
> https://gist.github.com/nathanrice/6143003
>
> There is no exception in the switch statement for html5 support, so the
> function just returns true (early) if `html5` is supported at all. The
> second parameter is essentially ignored.
>
> So, if you intend to turn on html5 output for just 1 of the 3 options, it
> doesn't matter. All 3 will output in html5.
>
> Which is, perhaps, intentional. I'm really not sure.
>
> If not, I'm prepping a patch to correct it.

New description:

 The check for the second parameter in `current_theme_supports()` in
 [24417] is irrelevant.

 Unit test here:
 https://gist.github.com/nathanrice/6143003

 There is no exception in the switch statement for html5 support, so the
 function just returns true (early) if `html5` is supported at all. The
 second parameter is essentially ignored.

 So, if you intend to turn on html5 output for just 1 of the 3 options, it
 doesn't matter. All 3 will output in html5.

 Which is, perhaps, intentional. I'm really not sure.

 If not, I'm prepping a patch to correct it.

--

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24932#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software