[wp-trac] [WordPress Trac] #20660: wp_get_attachment_url() ignores filter for unrecognized IDs
WordPress Trac
noreply at wordpress.org
Tue Aug 20 07:25:02 UTC 2013
#20660: wp_get_attachment_url() ignores filter for unrecognized IDs
-----------------------------+------------------------------
Reporter: RoamFree | Owner:
Type: feature request | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 2.1
Severity: minor | Resolution:
Keywords: |
-----------------------------+------------------------------
Changes (by markoheijnen):
* status: closed => reopened
* resolution: invalid =>
Comment:
I reopening this for second thoughts. The use case described is maybe not
the best one. I had a use case where core uses this function to request
the attachment url for a CPT I created. This because I was combining it in
the new media dialog. In this case there was another filter I could use
but I still think this was the best location to change it.
Also I do believe when you filter on the output that you should try to do
that always. Even when the output is false.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20660#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list