[wp-trac] [WordPress Trac] #25085: Twenty Fourteen: Fix Genericons Loading

WordPress Trac noreply at wordpress.org
Mon Aug 19 18:49:42 UTC 2013


#25085: Twenty Fourteen: Fix Genericons Loading
------------------------------+-----------------------------
 Reporter:  celloexpressions  |      Owner:
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Bundled Theme     |    Version:  trunk
 Severity:  normal            |   Keywords:
------------------------------+-----------------------------
 Regardless of whether or not Genericons are packaged in core (see #24864),
 we should load them with {{{wp_enqueue_style('generions', ... )}}} like we
 did with Twenty Thirteen (#24595) so that they play more nicely with
 plugins.

 Since the {{{genericons.css}}} file that is packaged with Genericons isn't
 currently loaded or accounted for, things break pretty severely when a
 plugin loads Genericons the "right way."

 This is what happens to the front page right sidebar when a plugin loads
 version 2.09 of {{{genericons.css}}}:
 [[Image()]]

 The problems come from the following css:
 {{{
 .genericon {
         display: inline-block;
         width: 16px;
         height: 16px;
         -webkit-font-smoothing: antialiased;
         font-size: 16px;
         line-height: 1;
         font-family: 'Genericons';
         text-decoration: inherit;
         font-weight: normal;
         font-style: normal;
         vertical-align: top;
 }
 }}}
 We'll need to make some adjustments in Twenty Fourteen's use of the
 {{{genericon}}} class to fix this. So, in summary, we need to
 {{{wp_enqueue_script()}}} and make Twenty Fourteen compatible with the
 default Genericons css.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25085>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list