[wp-trac] [WordPress Trac] #24874: Twenty Fourteen: Change to just one footer widget area and use Masonry
WordPress Trac
noreply at wordpress.org
Mon Aug 19 14:57:14 UTC 2013
#24874: Twenty Fourteen: Change to just one footer widget area and use Masonry
---------------------------+------------------
Reporter: Frank Klein | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.8
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+------------------
Comment (by obenland):
Nice patch Frank! Some minor nit picks that would make it beyond great:
* We try to not use IDs as selectors, to make it easy to override them.
* Let's call it a `'Footer Widget Area'` as it is not really a sidebar.
* Single line if/else blocks can omit braces for brevity
([http://make.wordpress.org/core/handbook/coding-standards/php/#brace-
style #])
* I think we can optimize the masonry selector to be just `#footer-
sidebar`.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24874#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list