[wp-trac] [WordPress Trac] #24967: Twenty Fourteen: Add ID to comment for closing div in sidebar.php

[WordPress Trac]

#24967: Twenty Fourteen: Add ID to comment for closing div in sidebar.php
---------------------------+----------------------
 Reporter:  Jonnyauk       |       Owner:
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Bundled Theme  |     Version:  trunk
 Severity:  minor          |  Resolution:  invalid
 Keywords:                 |
---------------------------+----------------------
Changes (by lancewillett):

 * keywords:  has-patch =>
 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Thanks Jonnyauk!

 We have a convention for this throughout the template files: if the
 element has only a class, that is the closing comment. If it has an ID,
 then we use just the ID.

 Noting this was fixed properly with r25023.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24967#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software