[wp-trac] [WordPress Trac] #25017: Dont allow empty $src parameter in wp_register_script
WordPress Trac
noreply at wordpress.org
Tue Aug 13 19:21:21 UTC 2013
#25017: Dont allow empty $src parameter in wp_register_script
--------------------------+------------------------------
Reporter: oskarhane | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.6
Severity: normal | Resolution:
Keywords: close |
--------------------------+------------------------------
Comment (by oskarhane):
Replying to [comment:6 nacin]:
> [23378] prevents blind unregistration of jQuery (and a number of other
critical scripts) on init. It allows it in the admin only if the person
knows what they are doing (which we infer by their use of the
admin_enqueue_scripts hook).
>
> There is also a login_enqueue_scripts hook that we can use to infer if
someone on wp-login.php knows what they are doing and should be allowed to
unregister jQuery. Otherwise we can just block the unregistration itself.
Yes, of course, I read it too fast and read "!==" as "==".
Adding that check would fix this issue!
--
Ticket URL: <http://core.trac.wordpress.org/ticket/25017#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list