[wp-trac] [WordPress Trac] #24977: Workflow change: automate RTL css generation
WordPress Trac
noreply at wordpress.org
Tue Aug 13 14:45:07 UTC 2013
#24977: Workflow change: automate RTL css generation
----------------------------+------------------
Reporter: yoavf | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.7
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
----------------------------+------------------
Comment (by nacin):
yoavf: This is fantastic. Let's start looking at how we can fix up the
sprites. At some point soon I suggest we commit this and get it out there
so others can see what's broken and contribute.
I think grunt-cssjanus should be in devDependencies in package.json. But
that might actually lead to a larger issue, that maybe it *isn't* just a
development dependency, as RTL is not usable without building. When we did
develop.svn, we wanted /src to be able to be executable as-is. This was
really important as we didn't want to make it more difficult to
contribute, and we also wanted to make it easy to run a "development"
version of WordPress, as in no need to even turn on SCRIPT_DEBUG.
koopersmith can talk a bit more about this, and I've let him know about
this thread.
The issue here is that you can't run /src in RTL, unless we also committed
the built RTL files to /src. We've previously discussed this for things
like a CSS preprocessor. If we adopted, say, SCSS, we would still want to
commit the compiled CSS to /src. It's possible that in this case we'd
still want to commit the -rtl.css files to core. The problem is we'd then
be conflating raw source with some kind of build output. So let's see what
koopersmith thinks.
A note though, this by no means prevents this from occurring for 3.7, nor
does it really affect the current patches or any future work on this
project. It just affects our future workflows.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24977#comment:29>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list