[wp-trac] [WordPress Trac] #24977: Workflow change: automate RTL css generation
WordPress Trac
noreply at wordpress.org
Mon Aug 12 13:22:38 UTC 2013
#24977: Workflow change: automate RTL css generation
----------------------------+------------------
Reporter: yoavf | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.7
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
----------------------------+------------------
Comment (by yoavf):
How to test this:
'''Prerequisites:''' [http://nodejs.org/ nodejs] and [http://gruntjs.com
/getting-started grunt]
{{{
$ mkdir rtltest
$ cd rtltest
$ svn co http://develop.svn.wordpress.org/trunk .
$ wget http://core.trac.wordpress.org/raw-
attachment/ticket/24977/24977.gruntfile.diff
$ patch -p0 -i 24977.gruntfile.diff
$ npm install https://github.com/yoavf/grunt-
cssjanus/archive/master.tar.gz
$ npm install (for other deps)
$ cd src
$ rm wp-includes/css/*-rtl.css
$ rm wp-admin/css/*-rtl.css
$ wget http://core.trac.wordpress.org/raw-
attachment/ticket/24977/24977.change_rtl_loading.diff
$ patch -p0 -i 24977.change_rtl_loading.diff
$ cd ..
$ grunt build
}}}
a {{{build}}} directory will be created. It contains a clean WP core
build, with the following changes applied:
1. Existing manually created rtl css files removed
1. Auto generated RTL css files added
1. Core RTL css files will be loaded instead of LTR css files (as defined
by the {{{wp_default_styles()}}} function, if the text direction is RTL
If you'd like to quickly test this build directory in RTL mode, you can
use the [wordpress.org/plugins/rtl-tester/ RTL Tester] plugin
As you'll quickly see, everything looks mostly OK - magic! However, there
are a bunch of issues with how the admin looks in this case - in most
cases related to sprites.
This is one of things to do next - each existing LTR css file needs to be
audited to make sure sprites are used properly. In some cases, we might
want to patch cssjanus itself if it isn't doing it's job properly.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24977#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list