[wp-trac] [WordPress Trac] #16758: PHP5-port - move of wpdb::check_database_version()

[WordPress Trac]

#16758: PHP5-port - move of wpdb::check_database_version()
-------------------------+----------------------
 Reporter:  hakre        |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  General      |     Version:  3.1
 Severity:  normal       |  Resolution:  wontfix
 Keywords:  has-patch    |
-------------------------+----------------------
Changes (by dd32):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 The suggested change here would cause DB dropins compatibility issues.

 For example, currently a DB dropin can replace the
 `wpdb::check_database_version()` method with a check for >= 1.0 (If that's
 the version of the server they require) and ignore the global
 `$required_mysql_version`.
 With this change, a DB Dropin would have to make sure it returned a MySQL
 version number >= `$required_mysql_version` in order to work, which would
 be a step backwards in becoming DB agnostic.

 I don't really see a problem with $wpdb relying on the global, When wpdb
 is used stand alone, the method wouldn't be used either.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/16758#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software