[wp-trac] [WordPress Trac] #10948: wp_list_comments() always assumes walker will echo.

[WordPress Trac]

#10948: wp_list_comments() always assumes walker will echo.
--------------------------+--------------------
 Reporter:  MikeLittle    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.7
Component:  Comments      |     Version:  2.8.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by nacin):

 Every other walker in core sets $output instead of directly echoing. I
 feel like Walker_Comment is doing it wrong and should be updated to do it
 properly. We would need to add an output buffer around the callback
 trigger in start_el() and such.

 The only other issue is if someone is extending Walker_Comment, especially
 only some of it. I am not sure what would happen then.

 So, do we:
  * Try to make the walker work more like all other walkers.
  * Add output buffering to where the walker is called.
  * ??

 I'm fine with committing [attachment:10948.diff] but it would still be
 nice to look at the walker inconsistencies.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/10948#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software