[wp-trac] [WordPress Trac] #24210: Issues found using a static analysis tool

[WordPress Trac]

#24210: Issues found using a static analysis tool
--------------------------+-----------------------
 Reporter:  rlerdorf      |       Owner:  nacin
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+-----------------------

Comment (by nacin):

 In [changeset:"24127"]:
 {{{
 #!CommitTicketReference repository="" revision="24127"
 Terms list table:
  * Don't call single_row() with an undeclared and unused $taxonomy
 argument.
  * Don't define optional parameters before required parameters in the
 _rows() method. Make them required.
  * Move empty( $terms ) check above other operations. This function was
 improperly returning an else case until [24123].

 props rlerdorf.
 see #24210.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24210#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software