[wp-trac] [WordPress Trac] #24210: Issues found using a static analysis tool

[WordPress Trac]

#24210: Issues found using a static analysis tool
--------------------------+------------------
 Reporter:  rlerdorf      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------

Comment (by SergeyBiryukov):

 [attachment:24210.2.patch] handles all the `UseVoidReturn` instances.

 `WP_Users_List_Table::single_row()` didn't require the change, as it
 actually returns the output, apparently for `wp_ajax_add_user()`, although
 that function doesn't appear to be used anywhere.

 `WP_Themes_List_Table::single_row()`, on the other hand, does not need to
 return the output and currently mixes string concatenation with direct
 echoing. The patch resolves that.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24210#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software