[wp-trac] [WordPress Trac] #24164: Deprecate `get_permalink()`
WordPress Trac
noreply at wordpress.org
Tue Apr 23 17:51:17 UTC 2013
#24164: Deprecate `get_permalink()`
-----------------------------+------------------------------
Reporter: ericmann | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Template | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------------+------------------------------
Comment (by johnpbloch):
Replying to [comment:6 itsananderson]:
> I've added a modification of Eric's patch that aliases get_permalink
rather than deprecating it. This way people can use the intuitive name,
but legacy code won't break or throw deprecated notices.
It doesn't make sense to me to add `get_the_permalink()` without
deprecating `get_permalink()`. It seems to me that doing so would only
further fragment the codebase rather than simplify and standardize it. The
discussion we need to have (and which Nacin has already started) is
whether the benefits of replacing `get_permalink()` with
`get_the_permalink()` outweigh the costs (the cost being that ~90% of
plugins and 100% of themes would need to update the function; not to avoid
''breaking'', but to avoid showing warnings when `WP_DEBUG` is enabled).
I personally think that the benefit does outweigh the cost.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24164#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list