[wp-trac] [WordPress Trac] #24136: Compare Two mode loads wrong post for left side when another post was created at the same time

[WordPress Trac]

#24136: Compare Two mode loads wrong post for left side when another post was
created at the same time
--------------------------+----------------------
 Reporter:  westi         |       Owner:  ocean90
     Type:  defect (bug)  |      Status:  closed
 Priority:  high          |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  critical      |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+----------------------

Comment (by adamsilverstein):

 i added some inline documentation in #23897;

 also did a little testing and verified the origin of all the -1 you see in
 the code - the diff values are indeed one off the model index.

  looks like jQuery UI slider reports leftmost position as 1 for two
 handled mode and 0 for one handled mode, the revisions code assumes left
 most position is 1 and behaves accordingly; since single handled mode
 returns left most as 0, it actually ADDS 1 to that value to keep it
 consistent with the two handled position.

 it might be possible to change the stored value in the slider callbacks
 instead, but i'm nervous about changing/breaking what already works.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24136#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software