[wp-trac] [WordPress Trac] #10205: getmyuid() called instead of posix_getuid() in get_filesystem_method() (wp-admin/includes/file.php)

WordPress Trac noreply at wordpress.org
Thu Apr 18 19:06:36 UTC 2013


#10205: getmyuid() called instead of posix_getuid() in get_filesystem_method() (wp-
admin/includes/file.php)
------------------------------------+-----------------------------
 Reporter:  pgl                     |       Owner:  dd32
     Type:  enhancement             |      Status:  reopened
 Priority:  normal                  |   Milestone:  Future Release
Component:  Filesystem              |     Version:  2.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------------

Comment (by thanatica2):

 {{{
 It's not a bug. It's by design. Any improvements on it are by definition
 an enhancement.
 }}}
 Nice one, you should become a project manager. It is a bug, because it's
 not working. If it's a bug or a buggy design is not important to neither
 the users nor the developers. It just needs fixing.

 Simply delete this line:
 {{{
 if ( getmyuid() == @fileowner($temp_file_name) )
 }}}
 And it's FIXED. It doesn't take two years to do that.

 Like other people have stated, WP only needs write access. Becoming file
 owner is simply not neccesary. If it has checked for create/write/delete
 access, than that's all it needs to carry on.

 What's more, it fails silently. The user is presented with a form that
 asks for FTP login info. WHY? At least report WHY auto-updates are
 failing. Silent fail is ALWAYS bad programming.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10205#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list