[wp-trac] [WordPress Trac] #24101: Argument for separating wp_nav_menu items

WordPress Trac noreply at wordpress.org
Tue Apr 16 12:06:50 UTC 2013


#24101: Argument for separating wp_nav_menu items
-----------------------------+------------------------------
 Reporter:  Clorith          |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Menus            |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |
-----------------------------+------------------------------
Changes (by toscho):

 * keywords:  has-patch => has-patch close


Comment:

 You can do that already with CSS or a filter on
 `walker_nav_menu_start_el`.

 Why is the separator at the end of the item and not at the start?

 There is a typo: `esparator`

 Make sure not to catch the wrong content with the regex: `'separator' =>
 'a'` would ruin the menu currently.

 The regex is probably very expensive on large menus. Why didn’t you use a
 counter and a plain additional string instead?

 What happens with nested menus?

 I think this is plugin/theme territory. The current walker is complex
 enough, and most people don’t need more arguments.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24101#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list