[wp-trac] [WordPress Trac] #23903: Revisions compare tweaks: Title, "To:" header

WordPress Trac noreply at wordpress.org
Thu Apr 11 23:45:05 UTC 2013


#23903: Revisions compare tweaks: Title, "To:" header
------------------------------------+--------------------
 Reporter:  markjaquith             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.6
Component:  Revisions               |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+--------------------
Changes (by adamsilverstein):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 Replying to [comment:4 faishal]:

 thank you for you patch!

 it worked as expected but i reworked a couple of things in
 [attachment:23903.diff 23903.diff]

 * show/hide the To: area using only CSS, no JS required as we area already
 adding a class to a parent div when the user switches to the compare two
 mode
 * cleaned up the label creation as per
 [http://make.wordpress.org/core/handbook/coding-standards/php/ WordPress
 coding standards]

 also, please note that its best to generate your diff from the root, that
 makes it easier to apply for testing :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23903#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list