[wp-trac] [WordPress Trac] #24023: 3.5/wp-includes/functions.php : missing break statement

WordPress Trac noreply at wordpress.org
Wed Apr 10 04:05:28 UTC 2013


#24023: 3.5/wp-includes/functions.php : missing break statement
--------------------------+-----------------------
 Reporter:  tivnet        |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:
Component:  General       |     Version:  3.5.1
 Severity:  trivial       |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------

Comment (by nacin):

 Replying to [comment:3 tivnet]:
 > The entire method can be changed to attempt to unserialize with catching
 the issued E_NOTICE.

 This method is written for speed. It's faster to reach into the string
 than attempt to unserialize. It's also why we use string functions rather
 than starting with regular expressions.

 You can't really catch an E_NOTICE, not without a custom error handler,
 which in turn is even slower.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24023#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list