[wp-trac] [WordPress Trac] #23469: Comment meta query is parsed before the pre_get_comments filter

WordPress Trac noreply at wordpress.org
Mon Apr 8 06:54:10 UTC 2013


#23469: Comment meta query is parsed before the pre_get_comments filter
--------------------------+------------------
 Reporter:  kasparsd      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Comments      |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by kasparsd):

 > But moving it would be a breaking change.

 I think `parse_query_vars`
 [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-
 includes/meta.php#L671 for meta_query] already takes care of double
 parsing, in case somebody is doing it manually on `pre_get_comments`.


 > Maybe we should just have another hook that happens before parsing.

 That could be a solution, but it would make the `pre_get_` filters
 inconsistent.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23469#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list